=== All Rounder === Contributors: themestulip Tags: custom-menu,one-column,right-sidebar,theme-options,threaded-comments,translation-ready,blog,custom-background,custom-colors,custom-header,custom-logo,editor-style,featured-images,full-width-template,two-columns Requires at least: 4.0 Tested up to: 6.4.2 Requires PHP: 5.2 License : GNU General Public License v2 or later License URI : http://www.gnu.org/licenses/gpl-2.0.html All Rounder WordPress Theme, Copyright 2024 themestulip(themestulip.com) All Rounder is distributed under the terms of the GNU GPL == Description == All Rounder multipurpose WordPress theme comes with great features such as its own slider, animation effect, parallax background feature, latest news, team members, photo gallery, social icons, shortcodes, custom widgets, page templates and blog sidebar. All Rounder WordPress has used for most of all type of business including Business consultant, news, portfolio, blogs, etc. Its used for the multipurpose business like Marketing, Finance, Stock Market, IT infrastructure, Consultant, Manufacture plant, Services, Retailer, Wholesaler, Online business, Store, IT Firm, Cloth business, and many more business For more info visit our demo: https://themestulip.com/demo/allrounder-pro/, Documentation link: https://themestulip.com/documentation/allrounder-pro/, Theme Page link: https://themestulip.com/themes/all-rounder-multipurpose-wordpress-theme/ == Changelog == = 1.0 = 1) Launched this version = 1.1 = 1) fixed error 2) Included cdn libery file in theme = 1.2 = 1) Use the theme customizer for implementing theme options. 2) fixed errors in responsive. = 1.3 = 1) fixed post page = 1.4 = Issues 1) REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/ Reply: This issue has been resolved 2) REQUIRED: All theme text strings are to be translatable. https://make.wordpress.org/themes/handbook/review/required/#language Reply: This issue has been resolved 3) REQUIRED: Please remove inline styling. Reply: This issue has been resolved 4) All scripts, stylesheets, Google Fonts, etc should be enqueued properly. https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts Reply: This issue has been resolved 5) REQUIRED: Required to use core-bundled scripts rather than including their own version of that script. For example jQuery. Reply: This issue has been resolved 6) REQUIRED: No minified files unless unminified version is also provided. Eg, if you are using bootstrap.min.css then you should also keep bootstrap.css. Reply: This issue has been resolved 7) REQUIRED: Demo content used in several places. Please remove those. Fields should be empty unless user enters data. Reply: This issue has been resolved 8) REQUIRED: In Customizer, Display Site Title and Tagline is not working. Reply: This issue has been resolved 9) REQUIRED: Please implement proper sanitization for values when saved to database. https://codex.wordpress.org/Data_Validation#Input_Validation Eg, sanitize_text_field() should be used to sanitize text field, esc_url_raw for URL field, for sanitizing field with HTML tags, use wp_kses_post() for sanitization, use absint() to sanitize positive integer. Reply: This issue has been resolved 10) REQUIRED: All untrusted data should be escaped properly before displaying. https://codex.wordpress.org/Data_Validation Eg, esc_url() should be used to escape URL, value in HTML attributes should be escaped with esc_attr(). Inside HTML content, esc_html() should be used. Reply: This issue has been resolved 11) RECOMMENDED: Third party script and style handle should not be prefixed. See https://make.wordpress.org/themes/handbook/review/recommended/#stylesheets-and-scripts Reply: This issue has been resolved 12) REQUIRED: There should not be menu parameter in wp_nav_menu() call. Use theme_location parameter. Reply: This issue has been resolved 13) REQUIRED: Please implement add_editor_style() properly. https://developer.wordpress.org/reference/functions/add_editor_style/ If you dont want to implement, please remove it. Reply: This issue has been resolved 14) REQUIRED: Please use get_template_directory() to load non template PHP files. Reply: This issue has been resolved 15) REQUIRED: Remove sticky-post theme tag if you dont want to implement. https://make.wordpress.org/themes/handbook/review/required/theme-tags/ Reply: This issue has been resolved 16) REQUIRED: Escape home_url() with esc_url(). Reply: This issue has been resolved 17) REQUIRED: Static value inside HTML attributes like placeholder, title, etc should be translatable and escaped. Please check thoroughly. Reply: This issue has been resolved = 1.5 = 1) removing readme.md file = 1.5.1 = 1) editor-style.css now loading = 1.5.2 = 1) Theme gives error upon activation in all_rounder_theme_customization-settings.php file on L230 Reply: This issue has been resolved; 2) Theme also gives JavaScript error “ReferenceError: Popper is not defined” Reply: This issue has been resolved; 3) Escaping issues found - use esc_html_e instead of _e Reply: This issue has been resolved; 4) Translation issues found - strings are not translatable in search.php on L20 and L21. Reply: This issue has been resolved; = 1.5.3 = 1) escaping issues Reply: Issue has been solved now. = 1.5.4 = 1) Translating issues Reply: Issue has been solved now. = 1.5.5 = REQUIRED: Remove default demo contents like phone, address, social links, etc. Those should be displayed only after user enters data. Reply: Done REQUIRED: If theme have some kind of header banner feature then Custom Header should be used. Adding separate image field in theme option is not allowed. Ref - https://developer.wordpress.org/themes/functionality/custom-headers/ Reply: Done REQUIRED: Handle bootstrap.min should be bootstrap. Handle font-awesome.min should be font-awesome. Reply:Done REQUIRED: Required to use core-bundled scripts rather than including their own version of that script. For example jQuery. Remove jquery.min.js Reply: Done REQUIRED: readme.txt - URL and license of this image is missing. - aboutus.jpg Reply: Done, I have removed that image REQUIRED: Please implement add_editor_style() properly. https://developer.wordpress.org/reference/functions/add_editor_style/ If you dont want to implement, please remove it. Reply: Done, We have removed it REQUIRED: should be simple . Generally the_*() function does not need echo. Check other also. Reply: Done REQUIRED: [Content Creation] - Footer section - Please remove such textarea fields for that section. You can use widgets for such. (You can keep textarea for copyright and developed by field.) Reply: ok, as per your suggestion has changed it. done REQUIRED: What is this code for? $wp_customize->get_setting( 'blogname' )->transport = 'allrounderr'; $wp_customize->get_setting( 'blogdescription' )->transport = 'responsive'; Reply: Its nothing I have removed it, its mistakly added there. REQUIRED: Define variables should be prefixed with theme slug. Eg, DOCURL, etc. Reply: Done REQUIRED: 'sanitize_callback' => 'esc_textarea' - Use sanitize_textarea_field() to sanitize textarea. REeply: Done version: 1.5.6 REQUIRED: Social links are still shown in header in fresh install. Please disable those by default. Reply: That issue has solved. REQUIRED: headr.php - Value in HTML attributes like title should be translatable and escaped. Eg,title="facebook" should be title="". Reply: That issue has solved. REQUIRED: Remove jquery.js. jQuery is already available in core. You should use it instead. Remove jquery.min.js also. Reply: That issue has solved. REQUIRED: Define variables should be prefixed with theme slug. Eg, DOCURL should be ALL_ROUNDER_DOCURL. Check other define variables also. Reply: That issue has solved. REQUIRED: define('DOCURL', 'http://themestulip.com/documentation/all-rounder','all-rounder'); - Can you please explain why you kept text domain here? Reply: I was used it for url purpose only, but now its change. That issue has solved. = 1.6 = REQUIRED: define('ALL_ROUNDER_DOCURL', 'http://themestulip.com/documentation/allrounder','all-rounder'); - You do not need textdomain here. Please check other define() also. Reply: That issue has solved with url change. = 1.6.1 = Screenhost Updated = 1.6.2 = Screenhost Updated, url updated, and wordpress version = 1.6.4 = tags, and desc updated = 1.6.5 = added demo link = 1.6.6 = updated wrodpress version = 1.6.7 = * Change in readme.txt file and update wordpress version. = 1.6.8 = * Change in readme.txt file and update post feature image code. == Resources == Theme is Built using the following resource bundles. 1 - Font-Awesome Font Awesome 4.4.0 by @davegandy - http://fontawesome.io - @fontawesome License - http://fontawesome.io/license (Font: SIL OFL 1.1, CSS: MIT License) 2 - Images used from pxhere. pxhere provides images under CC0 license (https://creativecommons.org/about/cc0) Home Header Images https://pxhere.com/en/photo/860251 Inner Page Images https://pxhere.com/en/photo/893376